-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Define base appearance for <select> #10629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing the base appearance style sheet?
Thanks for the review! I just pushed a lot of changes.
I have a separate PR for that here: #10670 I can get rid of that PR and include it in this PR if you'd prefer. |
I added paragraphs for opening the picker and moving focus between options |
from whatnot:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's remaining to resolve this? Is it spec'ing something like the "default event handler" thing in the discussion above, or are implementers fine with the spec in its state, reacting to events without such a mechanism? I'd love @smaug----'s opinion here.
This PR won't be merged and will instead be included in a bigger PR including all customizable select PRs: #10548 |
Define several concepts related to customizable <select>: - Relax the HTML parser to allow more tags inside <select> - Update the content model to allow more elements inside <select> and related elements. - Define rendering and some interactions for base appearance for <select> - Add the <selectedcontent> HTML element - Add a UA stylesheet for <select> with base appearance Closes whatwg#9799. Closes whatwg#10310. Closes whatwg#10317. Closes whatwg#10520. Closes whatwg#10762. The following pull requests are superseded: closes whatwg#10557; closes whatwg#10586; closes whatwg#10629; closes whatwg#10633; closes whatwg#10670.
This PR defines the base appearance except for the UA stylesheet for customizable select as proposed in #9799
Base appearance is being defined in CSS here: w3c/csswg-drafts#10691
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )
/rendering.html ( diff )