Skip to content

Explainer: Swap Chain #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Explainer: Swap Chain #1618

merged 3 commits into from
Apr 13, 2021

Conversation

kainino0x
Copy link
Contributor

No description provided.

@kainino0x kainino0x requested a review from Kangz April 9, 2021 03:04
@kainino0x kainino0x mentioned this pull request Apr 9, 2021
16 tasks
@kvark kvark merged commit 4aa7e32 into gpuweb:main Apr 13, 2021
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…eb#1619)

This PR simplifies the names of the existing tests with descriptions.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…lear_value (gpuweb#1640)

If depthLoadOp of depthStencilAttachment is "clear", depthClearValue
must be between 0.0 and 1.0. So, this PR adds a test to check if
depthClearValue is invalid if the value is out of the range.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…b#1630)

No two entries in timestampWrites have the same location. So,
this PR adds a test to ensure that two timestampWrite don't
have the same location.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…eb#1639)

This is the second PR to simplify the names of the existing tests
with descriptions.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…eb#1651)

This is the last PR to simplify the names of the existing tests
with descriptions.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…#1652)

If occlusionQuerySet is not null, the type should be occlusion.
So, this PR adds a test to check if the type is invalid if the
type is not occlusion.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…eb#1654)

The count of the querySet should be greater than the queryIndex
of timestampWrite. So, this PR adds a test to check if a validation
error is generated when the query index is greater than the count of
the query set.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…puweb#1653)

The queryType of each timestampWrite in timestampWrites should be
`timestamp`. So, this PR adds a test to check if a validation error
is generated if all query set types aren't `timestamp`.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…puweb#1656)

Each timestampWrite of the timestampWrites should not have the same
queiryIndex if each timestampWrite has the same querySet. So, this
PR adds a test to check if a validation error is generated when
queryIndexes are equal in the timestampWrites.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…ogether (gpuweb#1660)

The `resolveTarget,usage` test has only tested an invalid case
(COPY_SRC | COPY_DST). So this PR adds more cases to check if
the resolveTarget usage is valid.

Issue: gpuweb#1618
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…ar_value (gpuweb#1674)

This PR updates render_pass_descriptor:depth_stencil_attachment_depth_clear_value
to check if out of range of depthClearValue is only invalid when depthLoadOp is
`clear'. If depthLoadOp is not `clear`, depthClearValue should be valid even
though the value is out of range.

Issue: gpuweb#1618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants