-
Notifications
You must be signed in to change notification settings - Fork 330
Explainer: Swap Chain #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Explainer: Swap Chain #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kangz
approved these changes
Apr 9, 2021
kvark
reviewed
Apr 12, 2021
kvark
approved these changes
Apr 13, 2021
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…eb#1619) This PR simplifies the names of the existing tests with descriptions. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…lear_value (gpuweb#1640) If depthLoadOp of depthStencilAttachment is "clear", depthClearValue must be between 0.0 and 1.0. So, this PR adds a test to check if depthClearValue is invalid if the value is out of the range. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…b#1630) No two entries in timestampWrites have the same location. So, this PR adds a test to ensure that two timestampWrite don't have the same location. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…eb#1639) This is the second PR to simplify the names of the existing tests with descriptions. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…eb#1651) This is the last PR to simplify the names of the existing tests with descriptions. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…#1652) If occlusionQuerySet is not null, the type should be occlusion. So, this PR adds a test to check if the type is invalid if the type is not occlusion. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…eb#1654) The count of the querySet should be greater than the queryIndex of timestampWrite. So, this PR adds a test to check if a validation error is generated when the query index is greater than the count of the query set. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…puweb#1653) The queryType of each timestampWrite in timestampWrites should be `timestamp`. So, this PR adds a test to check if a validation error is generated if all query set types aren't `timestamp`. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…puweb#1656) Each timestampWrite of the timestampWrites should not have the same queiryIndex if each timestampWrite has the same querySet. So, this PR adds a test to check if a validation error is generated when queryIndexes are equal in the timestampWrites. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…ogether (gpuweb#1660) The `resolveTarget,usage` test has only tested an invalid case (COPY_SRC | COPY_DST). So this PR adds more cases to check if the resolveTarget usage is valid. Issue: gpuweb#1618
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…ar_value (gpuweb#1674) This PR updates render_pass_descriptor:depth_stencil_attachment_depth_clear_value to check if out of range of depthClearValue is only invalid when depthLoadOp is `clear'. If depthLoadOp is not `clear`, depthClearValue should be valid even though the value is out of range. Issue: gpuweb#1618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.