Skip to content

Explainer: Object validity and destroyedness #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2021
Merged

Conversation

Kangz
Copy link
Contributor

@Kangz Kangz commented Apr 2, 2021

No description provided.

@Kangz Kangz requested review from kvark and kainino0x April 2, 2021 12:23
Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed copyediting commit, and moved image into repo (idk if really necessary but OK I think)

Calls become no-ops (aside from error reporting) when validation fails.
If the call returns a WebGPU object, then the returned object is also invalid (hence the term "contagious").

<img src="https://i.imgur.com/DY9GheM.png"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you happen to draw this in something that can export an SVG? Possibly smaller than a PNG and text could be searchable/selectable (I think) and editable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll export an SVG and make a PR with it.

@kvark kvark merged commit 329c0e6 into gpuweb:main Apr 5, 2021
@kainino0x kainino0x mentioned this pull request Apr 8, 2021
16 tasks
@Kangz Kangz deleted the explainer branch March 25, 2022 14:22
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants