feat(bindings/core): Enhance existing parse function to accept both string and buffer types(#10371)

blueavee · kdy1 · web-flow · commit c9a2afcfd1b6 · 2025-04-14T18:33:03.000+09:00
**Description:** - Enhanced existing `parse` and `parseSync` functions to accept string and Buffer inputs. - Updated TypeScript definitions and JavaScript bindings to reflect the new input types. - Improved tests to cover the new capabilities for parsing from both string and Buffer inputs. **Related issue:** - Closes #9876 --- Co-authored-by: Donny/강동윤 <kdy1997.dev@gmail.com>
diff --git a/bindings/binding_core_node/src/parse.rs b/bindings/binding_core_node/src/parse.rs
@@ -6,7 +6,7 @@ use std::{
 use anyhow::Context as _;
 use napi::{
     bindgen_prelude::{AbortSignal, AsyncTask, Buffer},
-    Env, Task,
+    Either, Env, Task,
 };
 use swc_core::{
     base::{
@@ -136,16 +136,24 @@ impl Task for ParseFileTask {
     }
 }
 
+fn stringify(src: Either<Buffer, String>) -> String {
+    match src {
+        Either::A(src) => String::from_utf8_lossy(src.as_ref()).into_owned(),
+        Either::B(src) => src,
+    }
+}
+
 #[napi]
 pub fn parse(
-    src: String,
+    src: Either<Buffer, String>,
     options: Buffer,
     filename: Option<String>,
     signal: Option<AbortSignal>,
 ) -> AsyncTask<ParseTask> {
     crate::util::init_default_trace_subscriber();
 
     let c = get_compiler();
+    let src = stringify(src);
     let options = String::from_utf8_lossy(options.as_ref()).to_string();
     let filename = if let Some(value) = filename {
         FileName::Real(value.into())
@@ -165,10 +173,15 @@ pub fn parse(
 }
 
 #[napi]
-pub fn parse_sync(src: String, opts: Buffer, filename: Option<String>) -> napi::Result<String> {
+pub fn parse_sync(
+    src: Either<Buffer, String>,
+    opts: Buffer,
+    filename: Option<String>,
+) -> napi::Result<String> {
     crate::util::init_default_trace_subscriber();
-    let c = get_compiler();
 
+    let c = get_compiler();
+    let src = stringify(src);
     let options: ParseOptions = get_deserialized(&opts)?;
     let filename = if let Some(value) = filename {
         FileName::Real(value.into())
diff --git a/packages/core/__tests__/parse/api_test.js b/packages/core/__tests__/parse/api_test.js
@@ -29,3 +29,17 @@ it("can be emit code back synchronously", async () => {
 
     expect(out.code.trim().replace("\n", "")).toBe(`class Foo {}`);
 });
+
+it("can be emit code back asynchronously for buffer input", async () => {
+    const m = await swc.parse(Buffer.from(`class Foo {}`));
+    const out = await swc.print(m);
+
+    expect(out.code.trim().replace("\n", "")).toBe(`class Foo {}`);
+});
+
+it("can be emit code back synchronously for buffer input", async () => {
+    const m = swc.parseSync(Buffer.from(`class Foo {}`));
+    const out = swc.printSync(m);
+
+    expect(out.code.trim().replace("\n", "")).toBe(`class Foo {}`);
+});
diff --git a/packages/core/binding.d.ts b/packages/core/binding.d.ts
@@ -24,13 +24,13 @@ export interface NapiMinifyExtra {
 
 export declare function newMangleNameCache(): object
 
-export declare function parse(src: string, options: Buffer, filename?: string | undefined | null, signal?: AbortSignal | undefined | null): Promise<string>
+export declare function parse(src: Buffer | string, options: Buffer, filename?: string | undefined | null, signal?: AbortSignal | undefined | null): Promise<string>
 
 export declare function parseFile(path: string, options: Buffer, signal?: AbortSignal | undefined | null): Promise<string>
 
 export declare function parseFileSync(path: string, opts: Buffer): string
 
-export declare function parseSync(src: string, opts: Buffer, filename?: string | undefined | null): string
+export declare function parseSync(src: Buffer | string, opts: Buffer, filename?: string | undefined | null): string
 
 export declare function print(programJson: string, options: Buffer, signal?: AbortSignal | undefined | null): Promise<TransformOutput>
 
