Skip to content

Unify <mark>'s UIA LocalizedControlType and AX AXRoleDescription #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dandclark
Copy link
Contributor

@dandclark dandclark commented Sep 5, 2019

Per https://w3c.github.io/html-aam/#el-mark, the UIA LocalizedControlType for <mark> is "mark" while the AXRoleDescription is "highlighted content". There is no good reason for these values to be different; this adds complexity for implementers and creates confusion for users when moving across platforms. Furthermore, "mark" is a confusing name for non-programmers, and "highlighted content" is unnecessary verbose.

This change switches both role descriptions to "highlight", removing the inconsistency and improving upon both existing names.

Closes #236

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.

Implementation commitment:

CC: @aleventhal @cookiecrook @boggydigital


Preview | Diff

@dandclark dandclark changed the title Make <mark>'s UIA LocalizedControlType and AX AXRoleDescription consi… Unify <mark>'s UIA LocalizedControlType and AX AXRoleDescription Sep 5, 2019
@dandclark dandclark marked this pull request as ready for review September 6, 2019 16:27
@scottaohara
Copy link
Member

scottaohara commented Sep 6, 2019

if Webkit will commit to implement, then this looks like a good change to me. Thank you

@dandclark
Copy link
Contributor Author

if Webkit will commit to implement, then this looks like a good change to me.

@cookiecrook , is this something you'd be able to comment on?

@gregwhitworth
Copy link

@cookiecrook Any update here? Thanks :)

@cookiecrook
Copy link
Collaborator

Seems like a good change.

WebKit bugzilla link above was broken, and I didn’t find an existing bug, so I filed a new one:

https://bugs.webkit.org/show_bug.cgi?id=201958

@cookiecrook
Copy link
Collaborator

PS. Looks like the Gecko link is also broken.

@dandclark
Copy link
Contributor Author

dandclark commented Sep 19, 2019

I updated the link to the WebKit bug and removed the broken Gecko link as this is N/A for them. [Correction: they'll still need to update their implementation but I assume the OK from WebKit is enough to move forward with this].
@scottaohara , is this PR good to complete now?
Thanks!

@scottaohara scottaohara merged commit 48b5dcf into w3c:gh-pages Sep 19, 2019
@scottaohara
Copy link
Member

thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<mark>'s UIA LocalizedControlType and AX AXRoleDescription should be unified
4 participants