test(parser): change tests in parser to scope analysis #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2019
JamesHenry
previously approved these changes
Feb 12, 2019
bradzacher
previously approved these changes
Feb 12, 2019
bradzacher
approved these changes
Feb 12, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
* Add `no-unnecessary-class` rule * Add metadata * ⬆️ eslint-docs
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes what is tested in parser fixture tests, we are doing parsing tests 2 times now in parser and ts-estree (redundant), instead of doing this now we are going to check how result of generated scope.