fix(eslint-plugin): improve detection of used vars in heritage #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 94.81% 94.83% +0.02%
==========================================
Files 48 48
Lines 2470 2480 +10
Branches 381 381
==========================================
+ Hits 2342 2352 +10
Misses 77 77
Partials 51 51
|
JamesHenry
approved these changes
Jan 21, 2019
This was referenced Jan 21, 2019
armanio123
pushed a commit
to armanio123/typescript-eslint
that referenced
this pull request
Jan 24, 2019
…Fixes typescript-eslint#102) (typescript-eslint#104) * Only check *.ts and *.tsx files (Fixes typescript-eslint#102) * Move duplicated isTypescript() function to util.js * Simplify regex in isTypescript()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue with heritage clause in classes and interfaces, it also reduces possible false possitives from class heritage when used as MemberExpression
fixes: #45