This repository was archived by the owner on Feb 18, 2025. It is now read-only.
This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Spec Review #60
Description
- Why do we need a "ASCII punctuators that need escaping" phrase?
- Can't we just define the chars inline in (the only place that it's used) the
CharSetconstruction? Eg, https://tc39.es/ecma262/#sec-compiletocharset'sCharacterClassEscape :: dproduction
- Can't we just define the chars inline in (the only place that it's used) the
- Nit: rename
cuListto something else. MaybeescapedList? - > If c is the first code point in cpList and c is a DecimalDigit, then
- I don't see the phrase "is the first … in" anywhere else. I think we can update that to state "if
cuListis empty" and use a defined "is empty" phrase and keep the same behavior.
- I don't see the phrase "is the first … in" anywhere else. I think we can update that to state "if
- There are several references to
cuListthat need to become_cuList_ - > Append the elements of the UTF16Encoding (10.1.1) of c to cuList
- What is UTF16Encoding? That 10.1.1 is
10.1.1 [[GetPrototypeOf]] ( )
- What is UTF16Encoding? That 10.1.1 is
- There are several
0x00XYreferences "unicode" references, shouldn't they all beU+00XY? -
DecimalDigitandWhiteSpaceshould be|DecimalDigit|and|WhiteSpace| - > and c is a DecimalDigit
cis a code point, can you compare it to aDecimalDigitproduction?
- u> and c is a WhiteSpace
cis a code point, can you compare it to aWhiteSpaceproduction?
- > c is a CharSetElement of toEscape
cis a code point needs to be cast to a CharSetElement before we can check if it's an element of the set.