Skip to content

inline IteratorStep so we can IteratorValue the result object #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

michaelficarra
Copy link
Member

@michaelficarra michaelficarra commented May 11, 2025

Fixes #21. Caused by a bad fix in #19. /cc @anba @bakkot @woess

@michaelficarra michaelficarra requested a review from bakkot May 11, 2025 14:54
Copy link
Collaborator

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was silly.

@bakkot
Copy link
Collaborator

bakkot commented May 11, 2025

Might also warrant a NOTE explaining why this is more complicated than the usual iteration?

@michaelficarra
Copy link
Member Author

@bakkot I think things like NOTEs can be figured out in the Stage 4 PR. I consider that integration.

@michaelficarra michaelficarra merged commit a67a285 into main May 12, 2025
2 checks passed
@michaelficarra michaelficarra deleted the GH-21 branch May 12, 2025 00:54
michaelficarra added a commit that referenced this pull request Jun 20, 2025
This effectively reverts #19/#23 (reading the last IteratorResult value)
and #18 (re-using IteratorResult objects).
michaelficarra added a commit that referenced this pull request Jun 20, 2025
This effectively reverts #19/#23 (reading the last IteratorResult value)
and #18 (re-using IteratorResult objects).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IteratorStep result == done cannot be passed to IteratorValue
2 participants