Skip to content

fully match yield* by doing one last IteratorValue #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

michaelficarra
Copy link
Member

This mirrors the IteratorValue done in 15.5.5 step 7.a.v.1 so that Iterator.concat better matches doing a yield* on the passed iterables.

/cc @anba

Copy link

@anba anba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelficarra michaelficarra merged commit 26bd708 into main Dec 3, 2024
2 checks passed
@michaelficarra michaelficarra deleted the match-yield-star branch December 3, 2024 13:52
ptomato pushed a commit to michaelficarra/test262 that referenced this pull request May 29, 2025
ptomato pushed a commit to tc39/test262 that referenced this pull request May 29, 2025
ptomato added a commit to tc39/test262 that referenced this pull request May 29, 2025
ptomato added a commit to tc39/test262 that referenced this pull request May 30, 2025
michaelficarra added a commit that referenced this pull request Jun 20, 2025
This effectively reverts #19/#23 (reading the last IteratorResult value)
and #18 (re-using IteratorResult objects).
michaelficarra added a commit that referenced this pull request Jun 20, 2025
This effectively reverts #19/#23 (reading the last IteratorResult value)
and #18 (re-using IteratorResult objects).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants