Skip to content

crypto: fix cross-realm SharedArrayBuffer validation #57974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

crypto: fix cross-realm SharedArrayBuffer validation #57974

merged 1 commit into from
Apr 24, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 22, 2025

#57828 only fixed the code for ArrayBuffer, let's handle SharedArrayBuffer as well. This also refactors the test to include the nits that didn't make it in the original PR.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 22, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (6bf7fd7) to head (2454b4b).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57974   +/-   ##
=======================================
  Coverage   90.27%   90.28%           
=======================================
  Files         630      630           
  Lines      186168   186158   -10     
  Branches    36482    36479    -3     
=======================================
- Hits       168066   168065    -1     
+ Misses      10975    10966    -9     
  Partials     7127     7127
Files with missing lines Coverage Δ
lib/internal/crypto/webidl.js 98.60% <100.00%> (+0.11%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66414/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5d15cbb into nodejs:main Apr 24, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5d15cbb

@aduh95 aduh95 deleted the cross-realm-sab branch April 24, 2025 14:05
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
crypto: fix cross-realm SharedArrayBuffer validation
b34212b 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
crypto: fix cross-realm SharedArrayBuffer validation
234c710 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
c6e8307 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
2ed01b2 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95 @RafaelGSS
crypto: fix cross-realm SharedArrayBuffer validation
8be5418 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 16, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
f02f562 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
6d2664e 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
d010962 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
61e5717 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 18, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
5afb3e7 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
crypto: fix cross-realm SharedArrayBuffer validation
53c5fdc 
PR-URL: #57974
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@AuntyEms AuntyEms mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@jasnell jasnell jasnell approved these changes

@legendecas legendecas legendecas approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @ljharb @jasnell @legendecas @marco-ippolito