src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57578

Aditi-1400 · 2025-03-21T14:22:03Z

According to V8's public API documentation, local handles (i.e., objects of type v8::Local) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of v8::Local, specifically the std::vector<v8::Local<v8::String>> with recently introduced v8::LocalVector<T>.

This is first of the series of commits to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>.

nodejs-github-bot · 2025-03-21T14:22:08Z

Review requested:

@nodejs/startup

src/node_builtins.cc

codecov · 2025-03-21T15:41:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (922ce9d) to head (c8f2584).
Report is 183 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57578      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.02%     
==========================================
  Files         629      630       +1     
  Lines      184939   185054     +115     
  Branches    36232    36249      +17     
==========================================
+ Hits       166885   166961      +76     
- Misses      11011    11036      +25     
- Partials     7043     7057      +14

Files with missing lines	Coverage Δ
src/node_builtins.cc	`79.12% <100.00%> (+1.13%)`	⬆️
src/node_builtins.h	`100.00% <ø> (ø)`

... and 57 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

According to V8's public API documentation, local handles (i.e., objects of type v8::Local<T>) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of `v8::Local`, specifically the `std::vector<v8::Local<v8::String>>` with recently introduced `v8::LocalVector<T>`. This is first of the series of commits to replace all `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>`.

A follow up of nodejs#57578 to replace all replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Refs: nodejs#57578

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Refs: #57578 PR-URL: #57733 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>

nodejs-github-bot · 2025-04-10T16:46:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66190/

Refs: nodejs#57578 PR-URL: nodejs#57733 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>

A follow up of #57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T> PR-URL: #57642 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Refs: #57578 PR-URL: #57646 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

According to V8's public API documentation, local handles (i.e., objects of type v8::Local<T>) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of `v8::Local`, specifically the `std::vector<v8::Local<v8::String>>` with recently introduced `v8::LocalVector<T>`. This is first of the series of commits to replace all `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>`. PR-URL: #57578 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>

A follow up of #57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T> PR-URL: #57642 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Refs: #57578 PR-URL: #57646 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

According to V8's public API documentation, local handles (i.e., objects of type v8::Local<T>) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of `v8::Local`, specifically the `std::vector<v8::Local<v8::String>>` with recently introduced `v8::LocalVector<T>`. This is first of the series of commits to replace all `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>`. PR-URL: #57578 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>

A follow up of #57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T> PR-URL: #57642 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Refs: #57578 PR-URL: #57646 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

According to V8's public API documentation, local handles (i.e., objects of type v8::Local<T>) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of `v8::Local`, specifically the `std::vector<v8::Local<v8::String>>` with recently introduced `v8::LocalVector<T>`. This is first of the series of commits to replace all `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>`. PR-URL: #57578 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>

A follow up of #57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T> PR-URL: #57642 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>

Refs: #57578 PR-URL: #57646 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

nodejs/node#57578

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>

nodejs/node#57578

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>

nodejs/node#57578

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 * chore: fix out of date patch --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 21, 2025

anonrig reviewed Mar 21, 2025

View reviewed changes

src/node_builtins.cc Outdated Show resolved Hide resolved

anonrig requested a review from jasnell March 21, 2025 15:33

Aditi-1400 force-pushed the replace-vector branch from 9384897 to c8f2584 Compare March 21, 2025 17:08

legendecas approved these changes Mar 21, 2025

View reviewed changes

anonrig approved these changes Mar 22, 2025

View reviewed changes

RaisinTen approved these changes Mar 22, 2025

View reviewed changes

jasnell approved these changes Mar 22, 2025

View reviewed changes

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 26, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

57d35f7

A follow up of nodejs#57578 to replace all replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 26, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

f0394c6

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 26, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

d0175c7

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Aditi-1400 mentioned this pull request Mar 26, 2025

Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 2) #57642

Merged

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 26, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

30d022e

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 26, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

2581400

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 27, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

4214598

Refs: nodejs#57578

Aditi-1400 mentioned this pull request Mar 27, 2025

Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 3) #57646

Merged

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 27, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

24bb4c7

Refs: nodejs#57578

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 27, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

bacda14

Refs: nodejs#57578

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Mar 27, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

44691fc

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Aditi-1400 mentioned this pull request Apr 2, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57733

Merged

Aditi-1400 added a commit to Aditi-1400/node that referenced this pull request Apr 2, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

54ff50f

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

codebytere added a commit to electron/electron that referenced this pull request May 23, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

6a78e17

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request May 26, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

4aa4a1e

nodejs/node#57578

This was referenced May 28, 2025

tools: check for std::vector<v8::Local> in lint #58497

Merged

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #58500

Merged

codebytere added a commit to electron/electron that referenced this pull request May 29, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

37c7e2b

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request Jun 2, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

303ebc4

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

394889e

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

1805bd7

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

91c6f77

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

125cf08

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

2b0d0c8

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

dd416aa

nodejs/node#57578

codebytere added a commit to electron/electron that referenced this pull request Jun 6, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

7aeeb92

nodejs/node#57578

ghost mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

codebytere added a commit to electron/electron that referenced this pull request Jun 18, 2025

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

4df0cca

nodejs/node#57578

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57578

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57578

Uh oh!

Aditi-1400 commented Mar 21, 2025

Uh oh!

nodejs-github-bot commented Mar 21, 2025

Uh oh!

Uh oh!

codecov bot commented Mar 21, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented Apr 10, 2025

Uh oh!

Uh oh!

Uh oh!

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57578

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57578

Uh oh!

Conversation

Aditi-1400 commented Mar 21, 2025

Uh oh!

nodejs-github-bot commented Mar 21, 2025

Uh oh!

Uh oh!

codecov bot commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 10, 2025

Uh oh!

Uh oh!

codecov bot commented Mar 21, 2025 •

edited

Loading