Skip to content

src: add BaseObjectPtr nullptr operations #56585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

src: add BaseObjectPtr nullptr operations #56585

merged 1 commit into from
Apr 10, 2025

Conversation

legendecas
Copy link
Member

Allow comparing a BaseObjectPtr or implicitly construct a
BaseObjectPtr with nullptr.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 13, 2025
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov

This comment was marked as outdated.

Sign in to view
jasnell
jasnell reviewed Jan 13, 2025
View reviewed changes
addaleax
addaleax reviewed Jan 13, 2025
View reviewed changes
@legendecas legendecas force-pushed the base-object-ptr-nullptr branch from 7d35dba to 06cb322 Compare January 22, 2025 11:07
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecas
src: add BaseObjectPtr nullptr operations
0d69bb8 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
@legendecas legendecas force-pushed the base-object-ptr-nullptr branch from 06cb322 to 0d69bb8 Compare January 23, 2025 09:47
@legendecas
Copy link
Member Author

Rebased to fix the failures that were on the main branch

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64681/

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66187/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit f692878 into nodejs:main Apr 10, 2025
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f692878

@legendecas legendecas deleted the base-object-ptr-nullptr branch April 10, 2025 16:43
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@legendecas @JonasBa
src: add BaseObjectPtr nullptr operations
2e00a0e 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: nodejs#56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@legendecas @RafaelGSS
src: add BaseObjectPtr nullptr operations
9f691e8 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@legendecas @RafaelGSS
src: add BaseObjectPtr nullptr operations
3435001 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@legendecas @aduh95
src: add BaseObjectPtr nullptr operations
1869b92 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@legendecas @RafaelGSS
src: add BaseObjectPtr nullptr operations
50958c8 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@legendecas @aduh95
src: add BaseObjectPtr nullptr operations
dd94236 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
src: add BaseObjectPtr nullptr operations
c05005d 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
src: add BaseObjectPtr nullptr operations
c63910f 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
src: add BaseObjectPtr nullptr operations
8b3dd43 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@legendecas @aduh95
src: add BaseObjectPtr nullptr operations
682d558 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@legendecas @aduh95
src: add BaseObjectPtr nullptr operations
e00c1ec 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legendecas @nodejs-github-bot @jasnell @addaleax