fs: remove dirent.path
#55548
Merged
fs: remove dirent.path
#55548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
added
semver-major
nodejs-github-bot
added
fs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55548 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 654 654
Lines 187824 187811 -13
Branches 36134 36134
=======================================
- Hits 166060 166059 -1
+ Misses 15005 14992 -13
- Partials 6759 6760 +1
|
anonrig
approved these changes
Oct 26, 2024
LiviaMedeiros
approved these changes
Oct 28, 2024
targos
reviewed
Oct 28, 2024
Ethan-Arrowood
approved these changes
Nov 6, 2024
aduh95
force-pushed
the
remove-dirent.path
branch
from
842336a to
f819bc1
Compare
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
commit-queue
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Nov 14, 2024
PR-URL: nodejs#55548 Fixes: nodejs#55538 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
aduh95
force-pushed
the
remove-dirent.path
branch
from
1704be9 to
d224cf4
Compare
PR-URL: nodejs#55548 Fixes: nodejs#55538 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]>
aduh95
force-pushed
the
remove-dirent.path
branch
from
d224cf4 to
d9540b5
Compare
|
Landed in d9540b5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as blockedPRs that are blocked by other issues or PRs.
because it should land after #55547
Fixes: #55538