Skip to content

Conversation

Kangz
Copy link
Contributor

@Kangz Kangz commented Apr 6, 2021

Includes extensive copyediting by @kainino0x

@Kangz Kangz requested review from kvark and kainino0x April 6, 2021 16:25
Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming no major edits since I copyedited. LGTM including formatting stuff.

@Kangz
Copy link
Contributor Author

Kangz commented Apr 8, 2021

Addressed all comments, please take a look or merge!

@kvark kvark merged commit 49ece0d into gpuweb:main Apr 8, 2021
@kainino0x kainino0x mentioned this pull request Apr 8, 2021
16 tasks
@Kangz Kangz deleted the mapping_explainer branch March 25, 2022 14:21
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
…attachment (gpuweb#1600)

This PR adds test cases that check mipsLevelCount: 0 and arrayLayerCount: 0
to the render_pass,resolve:resolve_attachment test. A validation error should
be generated if resolveTargetViewMipCount or resolveTargetViewArrayLayerCount
is 0.

Issue: 1599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants