Skip to content

Add literate Haskell renderer using literati #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2012

Conversation

jm
Copy link

@jm jm commented Oct 31, 2012

This PR adds rendering literate Haskell files using Markdown and Bird-style comment markers. This is a very common pattern in the Haskell community.

@rtomayko
Copy link
Contributor

rtomayko commented Nov 8, 2012

Needs security and sanity review of literati. Can you link up the upstream repos for that project and any dependencies? /cc @vmg, @github/security.

Also who uses this? I feel like this is going to add more lines of code than people getting value from it which is a pretty bad ratio.

@jm
Copy link
Author

jm commented Nov 8, 2012

We've had a few halp tickets about asking for it; it's pretty popular. I've already had @vmg review the repo, but you can look at it at http://github.com/jm/literati. All it does is pre-process the files and convert them to Markdown; fairly simple (like 100 LOC or less).

@rtomayko
Copy link
Contributor

rtomayko commented Nov 8, 2012

Cool. Looks good to me.

rtomayko added a commit that referenced this pull request Nov 8, 2012
Add literate Haskell renderer using literati
@rtomayko rtomayko merged commit 6690c6f into github:master Nov 8, 2012
@rtomayko
Copy link
Contributor

rtomayko commented Nov 8, 2012

Woops. Merged that before checking the build output. Can you look into this first failure:

https://janky.rs.github.com/148206/output

@jbarnette
Copy link

I dropped a few superficial review comments as issues on jm/literati.

On Wed, Nov 7, 2012 at 8:56 PM, Ryan Tomayko [email protected]:

Woops. Merged that before checking the build output. Can you look into
this first failure:

https://janky.rs.github.com/148206/output


Reply to this email directly or view it on GitHubhttps://github.com//pull/162#issuecomment-10176892.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants