Implement Object.hasOwn #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
|
Thanks for the PR! One thing to note is that features in engine262 are flagged until they reach stage 4. You can do that by adding the feature to surroundingAgent.feature('whatever')
? ['hasOwn', Object_hasOwn, 2]
: undefined,If we also wait for your test PR to land, you can add the feature to |
devsnek
reviewed
May 26, 2021
devsnek
reviewed
May 29, 2021
The test262 tests have landed and I've updated this PR to add it to the features list. |
|
@jamiebuilds i pulled the latest test262 into main. if you rebase and enable the feature it should be good to go. |
Co-authored-by: devsnek <[email protected]>
Co-authored-by: devsnek <[email protected]>
Co-authored-by: devsnek <[email protected]>
jamiebuilds
force-pushed
the
object-hasown
branch
from
e4351fa to
313a677
Compare
|
@devsnek Updated |
devsnek
reviewed
Jun 17, 2021
Co-authored-by: devsnek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal just reached stage 3: https://github.com/tc39/proposal-accessible-object-hasownproperty
Spec: https://tc39.es/proposal-accessible-object-hasownproperty/