Skip to content

[JSC] Enable RegExp.escape #31557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

[JSC] Enable RegExp.escape #31557

merged 1 commit into from
Aug 1, 2024
+9 −3

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Jul 31, 2024 •
edited by webkit-early-warning-system
Loading

fc98407

[JSC] Enable `RegExp.escape`
https://bugs.webkit.org/show_bug.cgi?id=277406

Reviewed by Keith Miller and Yusuke Suzuki.

`RegExp.escape` proposal[1] reached Stage 3 in July 2024[2].

[1]: https://github.com/tc39/proposal-regex-escaping
[2]: https://github.com/tc39/agendas/blob/main/2024/07.md

* LayoutTests/js/Object-getOwnPropertyNames-expected.txt:
* LayoutTests/js/dom/regexp-caching-expected.txt:
* LayoutTests/js/script-tests/Object-getOwnPropertyNames.js:
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/281718@main

232d155

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@sosukesuzuki sosukesuzuki requested a review from a team as a code owner July 31, 2024 19:59
@sosukesuzuki sosukesuzuki self-assigned this Jul 31, 2024
@sosukesuzuki sosukesuzuki added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jul 31, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 31, 2024 •
edited
Loading

EWS run on previous version of this PR (hash d4635bf)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
❌ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

kmiller68
kmiller68 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me.

Constellation
Constellation approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@kmiller68 kmiller68 added the merge-queue Applied to send a pull request to merge-queue label Aug 1, 2024
@sosukesuzuki sosukesuzuki removed the merge-queue Applied to send a pull request to merge-queue label Aug 1, 2024
@sosukesuzuki sosukesuzuki force-pushed the eng/enable-regexp-escape branch from 51d0800 to 232d155 Compare August 1, 2024 08:49
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Aug 1, 2024 •
edited
Loading

EWS run on current version of this PR (hash 232d155)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 1, 2024
@sosukesuzuki @Constellation
[JSC] Enable RegExp.escape
fc98407 
https://bugs.webkit.org/show_bug.cgi?id=277406

Reviewed by Keith Miller and Yusuke Suzuki.

`RegExp.escape` proposal[1] reached Stage 3 in July 2024[2].

[1]: https://github.com/tc39/proposal-regex-escaping
[2]: https://github.com/tc39/agendas/blob/main/2024/07.md

* LayoutTests/js/Object-getOwnPropertyNames-expected.txt:
* LayoutTests/js/dom/regexp-caching-expected.txt:
* LayoutTests/js/script-tests/Object-getOwnPropertyNames.js:
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/281718@main
@webkit-commit-queue
Copy link
Collaborator

Committed 281718@main (fc98407): https://commits.webkit.org/281718@main

Reviewed commits have been landed. Closing PR #31557 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fc98407 into WebKit:main Aug 1, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 1, 2024
@ljharb
Copy link
Contributor

ljharb commented Oct 21, 2024

Any idea in which Safari version this will become available?

@ljharb ljharb mentioned this pull request Oct 21, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@kmiller68 kmiller68 kmiller68 approved these changes

Assignees

@sosukesuzuki sosukesuzuki

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sosukesuzuki @webkit-early-warning-system @webkit-commit-queue @ljharb @Constellation @kmiller68